It’s just data

bzr-feed updated to support bzr 0.90.0

My branch is here.  If all goes as it should, this change should be reflected shortly in the global bzr-feed feed.

=== modified file 'bzr-feed.py'
--- bzr-feed.py 2007-03-14 11:51:45 +0000
+++ bzr-feed.py 2007-11-06 14:26:27 +0000
@@ -68,6 +68,10 @@
 
         print "      </ul></dd>"
 
+    def log_revision(self, lr):
+        delta = self.branch.get_revision_delta(int(lr.revno))
+        self.show(lr.revno, lr.rev, delta)
+
     def show(self, revno, rev, delta):
         revno = str(revno)
         message = rev.message.rstrip().split('\n')

Is that better than my solution from two months ago?

I emailed Morten about it (pointing to my feed), but never heard back.

Posted by Jacques Distler at

I either wasn’t aware of, or completely forgot about, your solution.

In any case, my version will likely continue to work with older versions of bzr; and furthermore will show the deltas.  I see that you added an if delta:, my first (uncommitted) version did that too, but all of my deltas were None which was unsatisfying.  I now call get_revision_delta to provide the list of change files.

Posted by Sam Ruby at

I see that you added an if delta:, my first (uncommitted) version did that too, but all of my deltas were None which was unsatisfying.

I think that’s because you didn’t set

  self.supports_delta = True

I forgot to do that, the first time around, and all my deltas were None, too.

Posted by Jacques Distler at

First off: Jacques, I’m sorry I haven’t returned to you, became a father just a few days after your mail, and it’s been sitting in my inbox since then.

I have now pulled your changes and added your feed to the global feed, and at least with the latest fix it seems to be working fine here with bzr 0.14, the version I’m still running...

Thanks!

Sam, you may have forgotten to commit your changes or something, as your feed doesn’t show your latest changes. Also, when I try bzr merge http://intertwingly.net/code/bzr-feed/, I get an error:

bzr: ERROR: Transport error: Server refuses to fullfil the request

Perhaps it’s because I’m behind on Bazaar?

Posted by Morten Høybye Frederiksen at

I’ve now replaced my branch with a simple pull of the latest.  Now the three of us should be in synch.

Posted by Sam Ruby at

Add your comment